Matthew Funcke

Python Essentials: Card Deck Class in 3 Steps

Your peek() method looks good - I can't suggest any way to improve it. But it looks like you forgot to add a return to your draw() method: return self._cards.pop(0) Your __init__() code will work. If you want to, you could make it into just one loop if you do something like this:for c in range(0,52*total_decks): ____ self.place_card(Card(c%52)) Also, in init(), you're adding a class field `self.decks`. It's better to use a local variable, otherwise you'll always a weird field that's giving false info to your class's users (i.e. "I'm made up of 0 decks of cards"). These are relatively minor suggestions.The only non-trivial bug I can see is in add_another_deck(). I was expecting an instance of CardDeck to be passed in. You're passing in a number that represents how many (new) CardDecks to create and add. For example, if you had: deck1, deck2 = CardDeck(), CardDeck() print(deck1) print(deck2) deck1.add_another_deck(deck2) print(deck1) print(deck2) You should get out: "Deck of 104 Cards" "Deck of 0 Cards"

I know you were asking for feedback before - and I'm happy to offer it - but this project is empty.

Sorry, somehow it's not saved, now attaching link to github.

My home work -<a href="https://github.com/Kasparaz/Cards" rel="nofollow">https://github.com/Kasparaz/Cards</a>

Company

Community

Teaching

Mobile

English

English

CardDeck_home_work

Company

Community

Teaching

Mobile

English

English